Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new release] ppx_deriving_protobuf (3.0.0) #18088

Merged
merged 5 commits into from
Feb 6, 2021
Merged

[new release] ppx_deriving_protobuf (3.0.0) #18088

merged 5 commits into from
Feb 6, 2021

Conversation

kit-ty-kate
Copy link
Member

A Protocol Buffers codec generator for OCaml

CHANGES:

@kit-ty-kate
[new release] ppx_deriving_protobuf (3.0.0)
9514e3f 
CHANGES:

  * Add support for OCaml 4.11 (ocaml-ppx/ppx_deriving_protobuf#36)
    (Thierry Martinez, review by Gabriel Scherer)
  * Add support for OCaml 4.12 (ocaml-ppx/ppx_deriving_protobuf#39)
    (Kate Deplaix, review by Gabriel Scherer)
  * Port to ppx_deriving 5.0 and ppxlib (ocaml-ppx/ppx_deriving_protobuf#39)
    (Kate Deplaix, review by Gabriel Scherer)
  * Upgrade the tests from ounit to ounit2 (ocaml-ppx/ppx_deriving_protobuf#39)
    (Kate Deplaix, review by Gabriel Scherer)
@camelus
Copy link
Contributor

camelus commented Feb 4, 2021 •
edited
Loading

Commit: 5129f20

Good to see you Madam.

☀️ All lint checks passed 5129f20
  • These packages passed lint tests: pa_ppx.0.03, ppx_deriving_protobuf.3.0.0
☀️ Installability check (+1)
  • new installable packages (1): ppx_deriving_protobuf.3.0.0

@kit-ty-kate
Copy link
Member Author

@chetmurthy any chance you'd know why pa_ppx.0.03 is failing here?

# make[2]: Leaving directory '/home/opam/.opam/4.10/.opam-switch/build/pa_ppx.0.03/runtime_fat'
# make[1]: Leaving directory '/home/opam/.opam/4.10/.opam-switch/build/pa_ppx.0.03/runtime_fat'
# make[1]: Entering directory '/home/opam/.opam/4.10/.opam-switch/build/pa_ppx.0.03/base'
# env TOP=.. ../tools/LAUNCH ocamlfind ocamlc    -for-pack Pa_ppx_base -linkall -package unix,compiler-libs.common,camlp5.quotations,camlp5.extfun,rresult,fmt,pa_ppx_utils,pa_ppx_runtime,compiler-libs.common -syntax camlp5r -c base.ml
# findlib: [WARNING] Interface topdirs.cmi occurs in several directories: /home/opam/.opam/4.10/lib/ocaml/compiler-libs, /home/opam/.opam/4.10/lib/ocaml
# File "base.ml", line 25, characters 45-46:
# 25 |     <:expr< $uid:runtime_module_path.val$ . $m$ >>
#                                                   ^
# Error: This expression has type MLast.expr
#        but an expression was expected of type string
# "ocamlfind" unexpectedly returned exit value 2 at ../tools/LAUNCH line 32.
# make[1]: *** [../config/Makefile:24: base.cmo] Error 2
# make[1]: Leaving directory '/home/opam/.opam/4.10/.opam-switch/build/pa_ppx.0.03/base'
# make: *** [Makefile:47: plugins] Error 2

@chetmurthy
Copy link
Contributor

Oops, sorry, just woke up. This is almost certainly b/c pa_ppx has to have copies of ocaml and camlp5 AST types: there's a mechanism for [at development time] generating them, storing in numbered directories, and then [at install time] fetching the correct version. I'm guessing something broke. Since your dep change fixed the problem, and 0.03 is a pre-release anyway, I'll leave things be.

@kit-ty-kate kit-ty-kate merged commit 17e1c83 into ocaml:master Feb 6, 2021
@kit-ty-kate kit-ty-kate deleted the release-ppx_deriving_protobuf-3.0.0 branch February 6, 2021 19:51
@chetmurthy
Copy link
Contributor

Now that I'm fully-caffeinated, I'll take a look and just make sure that there wasn't anything else wrong, and that whatever-it-is, it's resolved with the latest pa_ppx release.

@chetmurthy
Copy link
Contributor

OK, that's definitely a bug in the method by which I determine which generated-source to pull during the install process. Thanks for pointing me at this! I'll fix this in the latest version of pa_ppx. Ugh.

@chetmurthy
Copy link
Contributor

Found and fixed in pa_ppx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseri mseri mseri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kit-ty-kate @camelus @chetmurthy @mseri